Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework get-sequences endpoint to return metadata #1000

Open
TobiasKampmann opened this issue Feb 12, 2024 · 3 comments
Open

rework get-sequences endpoint to return metadata #1000

TobiasKampmann opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
backend related to the loculus backend component website Tasks related to the web application
Milestone

Comments

@TobiasKampmann
Copy link
Contributor

TobiasKampmann commented Feb 12, 2024

The first approach shows some shortcomings.

  1. the warning icon should be yellow, but due lazy loading thats not possible when only status infos are available
  2. the get-data-to-edit endpoint excludes RECEIVED and IN_PROCESSING statuses.

Solution:

Send data directly with the get-sequences call.

@TobiasKampmann TobiasKampmann added website Tasks related to the web application backend related to the loculus backend component labels Feb 12, 2024
@TobiasKampmann TobiasKampmann added this to the MVP (closed beta) milestone Feb 12, 2024
@TobiasKampmann TobiasKampmann self-assigned this Feb 12, 2024
@TobiasKampmann TobiasKampmann moved this to In Progress in Planning Feb 12, 2024
@TobiasKampmann TobiasKampmann removed this from the MVP (closed beta) milestone Feb 13, 2024
@chaoran-chen
Copy link
Member

@theosanderson, @fengelniederhammer, do you know whether this is still relevant?

@fengelniederhammer
Copy link
Contributor

It might be, yes. We're still fetching every individual entry after intially getting all sequences for the review page. But currently, I don't see it as a big problem, since it works.

@fhennig
Copy link
Contributor

fhennig commented Nov 18, 2024

We tried to refactor this, but in our initial implementation we realized that sequence data was also sent along, which was too much data to query every 10 seconds (#3189).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend related to the loculus backend component website Tasks related to the web application
Projects
Status: Backlog
4 participants