Make seqset tests more robust

loculus-project · May 12, 2024 · 791deac · 791deac
1 parent e88c9f2
commit 791deac
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/website/src/components/SeqSetCitations/SeqSetItemActions.tsx b/website/src/components/SeqSetCitations/SeqSetItemActions.tsx
@@ -1,4 +1,4 @@
-import { type FC, useState } from 'react';
+import { type FC, useState, useEffect } from 'react';
 
 import { ExportSeqSet } from './ExportSeqSet';
 import { SeqSetForm } from './SeqSetForm';
@@ -32,6 +32,11 @@ const SeqSetItemActionsInner: FC<SeqSetItemActionsProps> = ({
     const [editModalVisible, setEditModalVisible] = useState(false);
     const [exportModalVisible, setExportModalVisible] = useState(false);
     const { errorMessage, isErrorOpen, openErrorFeedback, closeErrorFeedback } = useErrorFeedbackState();
+    const [isClient, setIsClient] = useState(false);
+
+    useEffect(() => {
+        setIsClient(true);
+    }, []);
 
     const { mutate: deleteSeqSet } = useDeleteSeqSetAction(
         clientConfig,
@@ -51,13 +56,13 @@ const SeqSetItemActionsInner: FC<SeqSetItemActionsProps> = ({
             <div className='flex-row items-center justify-between w-full'>
                 <div className='flex justify-start items-center pt-4 pb-8'>
                     <div className='pr-2'>
-                        <button className='btn' onClick={() => setExportModalVisible(true)}>
+                        <button className='btn' onClick={() => setExportModalVisible(true)} disabled={!isClient}>
                             Export
                         </button>
                     </div>
                     <div className='px-2'>
                         {isAdminView ? (
-                            <button className='btn' onClick={() => setEditModalVisible(true)}>
+                            <button className='btn' onClick={() => setEditModalVisible(true)} disabled={!isClient}>
                                 Edit
                             </button>
                         ) : null}
@@ -72,6 +77,7 @@ const SeqSetItemActionsInner: FC<SeqSetItemActionsProps> = ({
                                         onConfirmation: handleDeleteSeqSet,
                                     })
                                 }
+                                disabled={!isClient}
                             >
                                 Delete
                             </button>

diff --git a/website/src/components/SeqSetCitations/SeqSetList.tsx b/website/src/components/SeqSetCitations/SeqSetList.tsx
@@ -1,5 +1,5 @@
 import MUIPagination from '@mui/material/Pagination';
-import { type FC, type MouseEvent, useState, useMemo } from 'react';
+import { type FC, type MouseEvent, useState, useMemo, useEffect } from 'react';
 
 import { routes } from '../../routes/routes';
 import type { SeqSet } from '../../types/seqSetCitation';
@@ -85,8 +85,13 @@ export const SeqSetList: FC<SeqSetListProps> = ({ seqSets, username }) => {
     const [order, setOrder] = useState<Order>('desc');
     const [orderBy, setOrderBy] = useState<keyof SeqSet>('createdAt');
     const [page, setPage] = useState(1);
+    const [isClient, setIsClient] = useState(false);
     const rowsPerPage = 5;
 
+    useEffect(() => {
+        setIsClient(true);
+    }, []);
+
     const handleRequestSort = (_: MouseEvent<unknown>, property: keyof SeqSet) => {
         const isAsc = orderBy === property && order === 'asc';
         setOrder(isAsc ? 'desc' : 'asc');
@@ -174,6 +179,7 @@ export const SeqSetList: FC<SeqSetListProps> = ({ seqSets, username }) => {
                                 className='hover:bg-primary-100 border-gray-100 cursor-pointer'
                                 onClick={(event) => handleClick(event, row.seqSetId, row.seqSetVersion.toString())}
                                 key={row.seqSetId}
+                                data-testid={isClient ? row.name : 'disabled'}
                             >
                                 <td className='px-2 whitespace-nowrap text-primary-900 pl-6'>
                                     {formatDate(row.createdAt)}

diff --git a/website/tests/pages/seqsets/seqset.page.ts b/website/tests/pages/seqsets/seqset.page.ts
@@ -12,7 +12,7 @@ export class SeqSetPage {
 
     public async gotoDetail(seqSetName: string = testSeqSet.name) {
         await this.gotoList();
-        await this.page.getByText(seqSetName).first().click();
+        await this.page.getByTestId(seqSetName).first().click();
         await this.page.waitForLoadState();
     }