Skip to content

Commit

Permalink
chore: test helm template and remove argo links (#654)
Browse files Browse the repository at this point in the history
* generate argocd links to lapis swagger per organism

* commit a helm template test

* move up and fix templateability check

* typo

* restore linebreak

* remove links
  • Loading branch information
theosanderson authored Dec 13, 2023
1 parent 5ae6849 commit 3b9c732
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
14 changes: 13 additions & 1 deletion .github/workflows/e2e-k3d.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,18 @@ jobs:
run: |
./deploy.py cluster
- name: Test helm template
uses: WyriHaximus/github-action-helm3@v3
with:
exec: helm template does-not-matter ./kubernetes/preview > defaultTemplate.yaml

- name: Upload default helm template
uses: actions/upload-artifact@v3
with:
name: default-helm-template
path: defaultTemplate.yaml


- name: Wait for Backend Docker Image
uses: lewagon/[email protected]
with:
Expand All @@ -42,7 +54,7 @@ jobs:
ref: ${{ github.ref }}
check-name: Build Website Docker Image
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Deploy with helm
uses: WyriHaximus/github-action-helm3@v3
with:
Expand Down
2 changes: 0 additions & 2 deletions kubernetes/preview/templates/ingressroute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ metadata:
namespace: {{ .Values.namespace }}
annotations:
cert-manager.io/cluster-issuer: "letsencrypt-prod"
link.argocd.argoproj.io/external-link: https://{{ $backendHost }}
spec:
entryPoints:
- websecure
Expand All @@ -52,7 +51,6 @@ metadata:
namespace: {{ .Values.namespace }}
annotations:
cert-manager.io/cluster-issuer: "letsencrypt-prod"
link.argocd.argoproj.io/external-link: https://{{ $keycloakHost }}
spec:
entryPoints:
- websecure
Expand Down
3 changes: 0 additions & 3 deletions kubernetes/preview/templates/lapis-ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ metadata:
namespace: {{ $.Values.namespace }}
annotations:
cert-manager.io/cluster-issuer: "letsencrypt-prod"
{{- if eq $.Values.environment "server" }}
link.argocd.argoproj.io/external-link: https://{{ $lapisHost }}
{{- end }}
spec:
entryPoints:
{{- if eq $.Values.environment "server" }}
Expand Down

0 comments on commit 3b9c732

Please sign in to comment.