feat: drupal 11 support #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekes
requested changes
Feb 11, 2025
...les/localgov_workflows_notifications/src/Form/LocalgovWorkflowsNotificationsSettingsForm.php
Outdated
Show resolved
Hide resolved
|
Ok we want this in as it unblocks services, which then unblocks step-by-step and guides. |
Assuming my comment #123 (comment) was correct.
|
Tagging all the everyone to get this approved :-) Just 8.4 implicit arguments errors from contrib. |
ekes
approved these changes
Feb 11, 2025
|
Sounds good - @stephen-cox and @millnut are happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #114, the bump to 10.2 minimum is for https://www.drupal.org/node/3404140
How to test
composer require localgovdrupal/localgov_workflows:"dev-feature/1.x/drupal-11-support as 1.3.8"Fails are eslint only.
How can we measure success?
Module works with both D10 and D11