Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coding standards introduced by latest drupal coder rules #115

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: coding standards introduced by latest drupal coder rules #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/localgov_review_date/tests/src/Functional/AdminSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Drupal\Tests\localgov_review_date\Functional;

use Drupal\Core\Cache\Cache;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\Tests\BrowserTestBase;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion modules/localgov_review_date/tests/src/Functional/ArchiveNodeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Drupal\Tests\localgov_review_date\Functional;

use Drupal\Core\Cache\Cache;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\Tests\BrowserTestBase;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion modules/localgov_review_date/tests/src/Functional/NodeFormTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Drupal\Tests\localgov_review_date\Functional;

use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_review_date\Entity\ReviewDate;
use Drupal\scheduled_transitions\Entity\ScheduledTransition;
use Drupal\Tests\BrowserTestBase;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion modules/localgov_review_date/tests/src/Functional/NodeTranslationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace Drupal\Tests\localgov_review_date\Functional;

use Drupal\Core\Cache\Cache;
use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_review_date\Entity\ReviewDate;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\Tests\BrowserTestBase;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
4 changes: 2 additions & 2 deletions modules/localgov_review_date/tests/src/Functional/RoleAccessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

namespace Drupal\Tests\localgov_review_date\Functional;

use Drupal\localgov_roles\RolesHelper;
use Drupal\node\NodeInterface;
use Drupal\Tests\BrowserTestBase;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\localgov_roles\RolesHelper;
use Drupal\node\NodeInterface;
use Symfony\Component\HttpFoundation\Response;

/**
Expand Down
4 changes: 2 additions & 2 deletions modules/localgov_review_date/tests/src/Kernel/ReviewDateEntityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

use Drupal\Core\Cache\Cache;
use Drupal\KernelTests\KernelTestBase;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\localgov_review_date\Entity\ReviewDate;
use Drupal\scheduled_transitions\Entity\ScheduledTransition;
use Drupal\scheduled_transitions\Form\ScheduledTransitionsSettingsForm;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion ...lgov_workflows_notifications/src/Plugin/EmailBuilder/WorkflowNotificationEmailBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class WorkflowNotificationEmailBuilder extends EmailBuilderBase {
* @param \Drupal\Core\Entity\ContentEntityInterface[] $entities
* Entities to notify about.
*/
public function createParams(EmailInterface $email, LocalgovServiceContactInterface $service_contact = NULL, array $entities = []): void {
public function createParams(EmailInterface $email, ?LocalgovServiceContactInterface $service_contact = NULL, array $entities = []): void {

$email->setParam('entities', $entities);
$email->setParam('service_contact', $service_contact);
Expand Down
2 changes: 1 addition & 1 deletion modules/localgov_workflows_notifications/tests/src/Functional/ServiceContactWidgetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Drupal\Tests\localgov_workflows_notifications\Functional;

use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_workflows_notifications\Entity\LocalgovServiceContact;
use Drupal\node\Entity\Node;
use Drupal\Tests\BrowserTestBase;

/**
* Test service contact widget.
Expand Down
2 changes: 1 addition & 1 deletion ...ocalgov_workflows_notifications/tests/src/Functional/WorkflowNotificationSettingsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
namespace Drupal\Tests\localgov_workflows_notifications\Functional;

use Drupal\Core\State\StateInterface;
use Drupal\localgov_workflows_notifications\NotificationTimerInterface;
use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_workflows_notifications\NotificationTimerInterface;

/**
* Test settings form.
Expand Down
4 changes: 2 additions & 2 deletions modules/localgov_workflows_notifications/tests/src/Kernel/ReviewNotificationCronHookTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@

use Drupal\Core\Queue\QueueInterface;
use Drupal\KernelTests\KernelTestBase;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\localgov_workflows_notifications\Entity\LocalgovServiceContact;
use Drupal\localgov_workflows_notifications\NotificationTimerInterface;
use Drupal\localgov_workflows_notifications\Plugin\QueueWorker\EmailNotificationQueueWorker;
use Drupal\node\Entity\Node;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;

/**
* Test the cron hook queuing review notifications.
Expand Down
4 changes: 2 additions & 2 deletions modules/localgov_workflows_notifications/tests/src/Kernel/ReviewNotificationEmailTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

use Drupal\Core\Queue\QueueInterface;
use Drupal\KernelTests\KernelTestBase;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\localgov_workflows_notifications\Entity\LocalgovServiceContact;
use Drupal\localgov_workflows_notifications\Plugin\QueueWorker\EmailNotificationQueueWorker;
use Drupal\symfony_mailer_test\MailerTestTrait;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;

/**
* Test the review notification email.
Expand Down
4 changes: 2 additions & 2 deletions modules/localgov_workflows_notifications/tests/src/Kernel/WorkflowNotificationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

use Drupal\Core\Queue\QueueInterface;
use Drupal\KernelTests\KernelTestBase;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\localgov_workflows_notifications\Entity\LocalgovServiceContact;
use Drupal\localgov_workflows_notifications\Plugin\QueueWorker\EmailNotificationQueueWorker;
use Drupal\localgov_workflows_notifications\WorkflowNotification;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;

/**
* Test the workflow notification service.
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Functional/ApprovalsDashboardTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

namespace Drupal\Tests\localgov_workflows\Functional;

use Drupal\localgov_roles\RolesHelper;
use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_roles\RolesHelper;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Functional/WorkflowsAccessTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

namespace Drupal\Tests\localgov_workflows\Functional;

use Drupal\Tests\BrowserTestBase;
use Drupal\localgov_roles\RolesHelper;
use Drupal\node\NodeInterface;
use Drupal\Tests\BrowserTestBase;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Kernel/WorkflowsScheduledTransitionsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace Drupal\Tests\localgov_workflows\Kernel;

use Drupal\KernelTests\KernelTestBase;
use Drupal\scheduled_transitions\Entity\ScheduledTransition;
use Drupal\Tests\node\Traits\ContentTypeCreationTrait;
use Drupal\Tests\node\Traits\NodeCreationTrait;
use Drupal\scheduled_transitions\Entity\ScheduledTransition;
use Drupal\workflows\Entity\Workflow;

/**
Expand Down