Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks for $is_syncing #110

Closed
wants to merge 1 commit into from
Closed

checks for $is_syncing #110

wants to merge 1 commit into from

Conversation

markconroy
Copy link
Member

Closes #109

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this is configuration getting changed.

I think the conflict check is harmless.

The service update is changing state

$this->state->set(self::LAST_RUN, $request_time);
which is database only so might actually be required.

@stephen-cox
Copy link
Member

None of changes made by the hook_install in the localgov_workflows_notifications module are config; one displays a meessage and the other initialises a var in Drupal state, so this change isn't required here.

@ekes
Copy link
Member

ekes commented Sep 3, 2024

I'm going to close this one, as both Stephen and me noted there are no config changes, and we mentioned the same at last MT.

@ekes ekes closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hook_install should not be making config changes when importing config ($is_syncing == TRUE)
3 participants