[WIP] Drupal 11 support

.github/workflows/test.yml

@@ -28,14 +28,25 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        localgov-version:
-          - '3.x'
-        drupal-version:
-          - '~10.0'
-        php-version:
-          - '8.1'
-          - '8.2'
-          - '8.3'
+        include:
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.1'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.2'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.3'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.4'
+          - localgov-version: '3.x'
+            drupal-version: '~11.0'
+            php-version: '8.3'
+          - localgov-version: '3.x'
+            drupal-version: '~11.0'
+            php-version: '8.4'
 
     steps:
       - name: Save git branch and git repo names to env if this is not a pull request
@@ -78,10 +89,17 @@ jobs:
           ref: php${{ matrix.php-version }}
 
       - name: Create LocalGov Drupal project
-        run: composer create-project --stability dev localgovdrupal/localgov-project:${COMPOSER_REF} ./html
+        run: |
+          composer create-project --stability dev --no-install localgovdrupal/localgov-project:${COMPOSER_REF} ./html
+          composer require --working-dir=./html --no-install --with-all-dependencies drupal/core-recommended:${{ matrix.drupal-version }} drupal/core-composer-scaffold:${{ matrix.drupal-version }} drupal/core-project-message:${{ matrix.drupal-version }} drupal/core-dev:${{ matrix.drupal-version }}
+          composer install --working-dir=./html
 
       - name: Obtain all dev dependencies for LocalGov Drupal
-        run: jq --raw-output '.packages[] | select(.name | startswith("localgovdrupal/")) | ."require-dev" | values | to_entries[] | @sh "\(.key):\(.value)"' ./html/composer.lock | sort | uniq | xargs composer --working-dir=./html require --dev --no-interaction
+        run: |
+          # We haven't aliased dev packages so this fails.
+          #jq --raw-output '.packages[] | select(.name | startswith("localgovdrupal/")) | ."require-dev" | values | to_entries[] | @sh "\(.key):\(.value)"' ./html/composer.lock | sort | uniq | xargs composer --working-dir=./html require --dev --no-interaction
+          # Just install the ones we need for now.
+          composer --working-dir=./html require --dev --no-interaction drupal/geofield_map drupal/group drupal/facets_form
 
   phpcs:
     name: Coding standards checks
@@ -96,7 +114,7 @@ jobs:
         drupal-version:
           - '~10.0'
         php-version:
-          - '8.3'
+          - '8.4'
 
     steps:
       - name: Cached workspace
@@ -130,7 +148,7 @@ jobs:
         drupal-version:
           - '~10.0'
         php-version:
-          - '8.3'
+          - '8.4'
 
     steps:
       - name: Cached workspace
@@ -158,14 +176,25 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        localgov-version:
-          - '3.x'
-        drupal-version:
-          - '~10.0'
-        php-version:
-          - '8.1'
-          - '8.2'
-          - '8.3'
+        include:
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.1'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.2'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.3'
+          - localgov-version: '3.x'
+            drupal-version: '~10.0'
+            php-version: '8.4'
+          - localgov-version: '3.x'
+            drupal-version: '~11.0'
+            php-version: '8.3'
+          - localgov-version: '3.x'
+            drupal-version: '~11.0'
+            php-version: '8.4'
 
     steps:
       - name: Clone Drupal container

.gitignore

@@ -1,5 +1,6 @@
 # Ignore directories generated by Composer
 /drush/contrib/
+/recipes/
 /vendor/
 /web/core/
 /web/modules/contrib/

.lando.dist.yml

@@ -1,9 +1,9 @@
 name: localgov
-recipe: drupal10
+recipe: drupal11
 config:
   webroot: web
-  php: '8.1'
-  database: mariadb:10.6
+  php: '8.3'
+  database: mariadb:10.11
 proxy:
   mailhog:
     - mail.localgov.lndo.site

composer.json

@@ -11,17 +11,18 @@
         }
     },
     "require": {
-        "composer/installers": "^1.10",
+        "composer/installers": "^1.10 || ^2.3",
         "cweagans/composer-patches": "^1.6",
-        "drupal/core-composer-scaffold": "^10.3",
-        "drupal/core-recommended": "^10.3",
-        "localgovdrupal/localgov": "^3.0",
-        "localgovdrupal/localgov_search_solr": "^1.1"
+        "drupal/core-composer-scaffold": "^10.3 || ^11.0",
+        "drupal/core-recommended": "^10.3 || ^11.0",
+        "localgovdrupal/localgov": "dev-feature/3.x/d11-support",
+        "localgovdrupal/localgov_search_solr": "^1.1",
+        "mglaman/composer-drupal-lenient": "^1.0"
     },
     "require-dev": {
-        "brianium/paratest": "^6.0",
+        "brianium/paratest": "^6.0 || ^7.3.1",
         "drupal/coder": "^8.3",
-        "drupal/core-dev": "^10.3",
+        "drupal/core-dev": "^10.3 || ^11.0",
         "mglaman/phpstan-drupal": "^1.0",
         "phpspec/prophecy-phpunit": "^2",
         "phpstan/phpstan": "^1.0",
@@ -40,11 +41,13 @@
         "allow-plugins": {
             "composer/installers": true,
             "cweagans/composer-patches": true,
+            "dealerdirect/phpcodesniffer-composer-installer": true,
             "drupal/core-composer-scaffold": true,
             "drupal/core-project-message": true,
+            "mglaman/composer-drupal-lenient": true,
+            "php-http/discovery": true,
             "phpstan/extension-installer": true,
-            "dealerdirect/phpcodesniffer-composer-installer": true,
-            "php-http/discovery": true
+            "tbachert/spi": true
         }
     },
     "extra": {
@@ -91,7 +94,11 @@
             "drush/Commands/contrib/{$name}": ["type:drupal-drush"],
             "web/modules/custom/{$name}": ["type:drupal-custom-module"],
             "web/themes/custom/{$name}": ["type:drupal-custom-theme"]
+        },
+        "drupal-lenient": {
+            "allowed-list": [
+                "drupal/facets_form"
+            ]
         }
-
     }
 }

phpunit.d11.xml.dist

@@ -0,0 +1,64 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<phpunit bootstrap="web/core/tests/bootstrap.php" colors="true"
+         beStrictAboutTestsThatDoNotTestAnything="true"
+         beStrictAboutOutputDuringTests="true"
+         beStrictAboutChangesToGlobalState="true"
+         failOnRisky="true"
+         failOnWarning="true"
+         displayDetailsOnTestsThatTriggerErrors="true"
+         displayDetailsOnTestsThatTriggerWarnings="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
+         cacheResult="false">
+
+  <php>
+    <!-- Set error reporting to E_ALL. -->
+    <ini name="error_reporting" value="32767"/>
+    <!-- Do not limit the amount of memory tests take to run. -->
+    <ini name="memory_limit" value="-1"/>
+    <!-- Example SIMPLETEST_BASE_URL value: http://localhost -->
+    <env name="SIMPLETEST_BASE_URL" value="http://localgov.lndo.site"/>
+    <!-- Example SIMPLETEST_DB value: mysql://username:password@localhost/databasename#table_prefix -->
+    <env name="SIMPLETEST_DB" value="mysql://database:database@database/database"/>
+    <!-- Example BROWSERTEST_OUTPUT_DIRECTORY value: /path/to/webroot/sites/simpletest/browser_output -->
+    <env name="BROWSERTEST_OUTPUT_DIRECTORY" value=""/>
+    <!-- To have browsertest output use an alternative base URL. For example if
+     SIMPLETEST_BASE_URL is an internal DDEV URL, you can set this to the
+     external DDev URL so you can follow the links directly.
+    -->
+    <env name="BROWSERTEST_OUTPUT_BASE_URL" value=""/>
+  </php>
+
+  <extensions>
+    <!-- Functional tests HTML output logging. -->
+    <bootstrap class="Drupal\TestTools\Extension\HtmlLogging\HtmlOutputLogger">
+      <!-- The directory where the browser output will be stored. If a relative
+        path is specified, it will be relative to the current working directory
+        of the process running the PHPUnit CLI. In CI environments, this can be
+        overridden by the value set for the "BROWSERTEST_OUTPUT_DIRECTORY"
+        environment variable.
+      -->
+      <parameter name="outputDirectory" value="sites/simpletest/browser_output"/>
+      <!-- By default browser tests print the individual links in the test run
+        report. To avoid overcrowding the output in CI environments, you can
+        set the "verbose" parameter or the "BROWSERTEST_OUTPUT_VERBOSE"
+        environment variable to "false". In GitLabCI, the output is saved
+        anyway as an artifact that can be browsed or downloaded from Gitlab.
+      -->
+      <parameter name="verbose" value="true"/>
+    </bootstrap>
+  </extensions>
+
+  <testsuites>
+    <testsuite name="profile">
+      <directory>web/profiles/contrib/localgov</directory>
+    </testsuite>
+    <testsuite name="modules">
+      <directory>web/modules/contrib/localgov_*</directory>
+    </testsuite>
+    <testsuite name="themes">
+      <directory>./web/themes/contrib/localgov_*</directory>
+    </testsuite>
+  </testsuites>
+
+</phpunit>

phpunit.xml.dist

@@ -4,6 +4,8 @@
          beStrictAboutTestsThatDoNotTestAnything="true"
          beStrictAboutOutputDuringTests="true"
          beStrictAboutChangesToGlobalState="true"
+         failOnWarning="true"
+         cacheResult="false"
          printerClass="\Drupal\Tests\Listeners\HtmlOutputPrinter">
 
   <php>