Login #92
Open
Login #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I replaced "find_element_by_xpath" with "find_element(By.XPATH "*"). When testing out the script, I get multiple warnings that the find_element_by_ method is deprecated and find_element() is the preferred method. This makes the output easier to diagnose when looking for bugs.
Cron scheduling script name was not correct. Was changed to: INSTEXE=$INSTDIR/noip-renew-$USER.sh
Update noip-renew.py
Update noip-renew-skd.sh
As @Angel0ffDeath discovered, the password is base64 encoded when setup.sh is run. Thus you can't just pass the encoded password to the field, it won't match the correct password. ele_pwd.send_keys(base64.b64decode(self.password).decode('utf-8')) will decode the password back to the acceptable text.
Restore password decoding
Login - Tested and works. This way you don't need to find Log In button.
simplified login submission logic
initial docker build and push support for #11
fixes #11
More elegant finding of username and password fields - no xpath; Browser waits until login page is loaded - waiting max of 10 sec or until login section appears in browser - If somebody has problems this could be increased to max of 20 or even 30 sec;; Browser waits after login to load my.noip.com page (this is not dynamic-dns page), but the page which loads after login - didn't had time to make it with explicit wait so I made it with implicit wait of 1 sec. For implicit wait some characteristic element should be used; The code is tested and working by me, but would appreciate your test results for improvement.
Updated Login and all sleeps removed
removed history and version as they are now tracked via github release and tag
Update README.md
Added tested versions of chrome webdriver and selenium
Update README.md
Updated selenium versions after testing
Added cronjob deleting on uninstall
This doesn't change the execution. Preparation for further altering with sed command from setup.sh
Update README.md
added cronjob deleting on unistall
Update noip-renew-skd.sh - preparation for change to resolve #42
small fix to x64 debian install
@neothematrix This change alters noip-renew-skd.sh if user wants randomized cronjob
Altering noip-renew-skd.sh - randomized cronjob
Sorry... found a typing mistake in my previous PR
fix a typo
Added info about randomized cronjob
2fa implementation
Fix 2FA changed form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login - Tested and works:
from selenium.webdriver.common.keys import Keys
comment the line
self.browser.find_element(By.XPATH, "//form[@id='clogs']/button[@type='submit']").click()
This way it is not necessary to find the button - something which works now but may not work if they change web page