Include UpstreamDebugEn-Sel to the AFC TI controlled parameters in Orbit Interlock HLIOC #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameters This helps ensure that upstream debug mode is disabled after any timing machine study.
anacso17
requested review from
fernandohds564,
murilobalves and
xresende
as code owners
ericonr
approved these changes
Feb 21, 2025
ericonr
requested changes
Feb 25, 2025
There was a problem hiding this comment.
This doesn't work, because AFCTI_CONFIGS is locked only for the AFC timings in the critical path, and we need to ensure debugging is disabled for all AFCs
I checked this by trying to change one of the currently locked PVs on crate 2 (it allowed me to change the value) and on crate 10 (it didn't allow me to change, and there was a message in the IOC log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps ensure that upstream debug mode is disabled after any timing machine study.