currinfo.FIX: set MAX_CURRENT to a higher value #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anacso17
requested review from
fernandohds564,
murilobalves and
xresende
as code owners
MAX_CURRENT is now 1A. This value is used to check if the Current measurements along BO ramp are valid values to be used at charge calculation, but the check consider as valid only values lower than MAX_CURRENT. Since injector optimization, the 150MeV current is bigger than 1A, so several measurements at this energy were ignored causing an erroneous calculation of accumulated charge at this energy.
anacso17
force-pushed
the
fix-bo-currinfo
branch
from
880a8a9 to
160e981
Compare
vellosok75
approved these changes
Feb 11, 2025
xresende
approved these changes
Feb 11, 2025
murilobalves
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAX_CURRENT is now 1A. This value is used to check if the Current measurements along BO ramp are valid values to be used at charge calculation, but the check consider as valid only values lower than MAX_CURRENT. Since injector optimization, the 150MeV current is bigger than 1A, so several measurements at this energy were ignored causing an erroneous calculation of accumulated charge at this energy.