Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quad Trims in IDFF #1134

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add Quad Trims in IDFF #1134

wants to merge 23 commits into from

Conversation

xresende
Copy link
Contributor

@xresende xresende commented Nov 28, 2024

TODO:

  • tests with IOC classes for IVU18 (trims)
  • tests with IOC for DELTA52 (ch, cv, qs)
  • rename correctors labels in existing si_idff configurations
  • Rename existing IDFF IOC PVs (correctors related)

@xresende xresende marked this pull request as ready for review December 4, 2024 11:33
@xresende
Copy link
Contributor Author

xresende commented Dec 4, 2024

these past few days I worked on this PR and had completely forgotten about PR #1064, which is now obsolete. But there are naming issues that we discussed there that I considered partially in this new PR. here I used general labels qa, qb and qc instead of the proposed qd1, qf and qd2 in the older PR. what do you think ?

@fernandohds564
Copy link
Contributor

these past few days I worked on this PR and had completely forgotten about PR #1064, which is now obsolete. But there are naming issues that we discussed there that I considered partially in this new PR. here I used general labels qa, qb and qc instead of the proposed qd1, qf and qd2 in the older PR. what do you think ?

I don't know, I think I prefer names directly related to the device names.

@anacso17
Copy link
Contributor

anacso17 commented Dec 4, 2024

Hi @xresende , I don't know too, what was the idea of the choice QA, QB, QC? It seems to be difficult to relate to the power supply names

@xresende
Copy link
Contributor Author

@fernandohds564 , @anacso17 , naming issues have been addressed and changes committed in this PR. last machine study I also tried all IDFF IOC (delta + IVUs with trimms) with this PR and they all worked. if you agree with the naming resolution proposed here i consider this PR ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants