-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Quad Trims in IDFF #1134
base: master
Are you sure you want to change the base?
Add Quad Trims in IDFF #1134
Conversation
these past few days I worked on this PR and had completely forgotten about PR #1064, which is now obsolete. But there are naming issues that we discussed there that I considered partially in this new PR. here I used general labels |
I don't know, I think I prefer names directly related to the device names. |
Hi @xresende , I don't know too, what was the idea of the choice QA, QB, QC? It seems to be difficult to relate to the power supply names |
@fernandohds564 , @anacso17 , naming issues have been addressed and changes committed in this PR. last machine study I also tried all IDFF IOC (delta + IVUs with trimms) with this PR and they all worked. if you agree with the naming resolution proposed here i consider this PR ready to be merged. |
TODO: