Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalizer #1100

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Fix normalizer #1100

merged 4 commits into from
Nov 1, 2024

Conversation

xresende
Copy link
Contributor

No description provided.

@fernandohds564
Copy link
Contributor

@xresende, isn't this one ready for revision? I think we could merge it and create an image for the IOCs, don't you think? Or you want to do this only after the P7Cav removal?

@xresende
Copy link
Contributor Author

xresende commented Oct 9, 2024

@xresende, isn't this one ready for revision? I think we could merge it and create an image for the IOCs, don't you think? Or you want to do this only after the P7Cav removal?

I still need to teste IOCs for power supplies other than trims. better wait a little bit.

@xresende xresende marked this pull request as ready for review October 22, 2024 15:59
@xresende xresende requested a review from vellosok75 October 22, 2024 16:00
Copy link
Contributor

@fernandohds564 fernandohds564 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works, but it doesn't seem very robust.
I'm approving anyway...

@xresende xresende merged commit 8d32261 into master Nov 1, 2024
2 checks passed
@xresende xresende deleted the fix-normalizer branch November 1, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants