-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
644 implement model registrator #651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I really like how clean it is, and it is exactly what we were thinking of.
Taking this further, we can now move on to thinking about how not to modify the default_model_config
object (it is really supposed to be read-only) and also lazy-loading only certain model configs as needed, but this is already pretty great!
Codecov ReportAttention: Patch coverage is
|
…l registration logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
This pull request introduces model registration functionality.
Model Registration:
register.py
for registering custom models in HSSM, including functionsregister_model
,list_registered_models
, andget_model_info
.src/hssm/__init__.py
to include theregister_model
function. [1] [2]Other updates
Dependency Updates:
ipython
,nbconvert
, andptpython
to thedev
dependencies inpyproject.toml
. [1] [2]Initialization Refactoring:
__init__
method insrc/hssm/hssm.py
to use a dictionary comprehension for initializingself._init_args
.