SAK-40994 - Fix auto-set of allow radio buttons (sakaiproject#6294)

Also add a readme and lean up a message.

basiclti/README_13.md

@@ -0,0 +1,30 @@
+
+How to add an LTI 1.3 tool to Sakai-19
+======================================
+
+Log in as admin / admin - go to Administration Workspace - Scroll down and select External Tools - Install LTI 1.x tool
+
+Consumer key and secret are  not needed if you are going to only use LTI 1.3.  If you want
+to test switching back and forth between LTI 1.1 and LTI 1.3.  The tool will specify the
+Consumer Key and Secret.  If this is Tsugi, the consumer key is based on the issuer so
+you you may have to add the tool in Sakai, Add it in Tsugi, and them come back and set
+the consumer key and secret in the tool entry.
+
+Put in the launch URL of the tool or Deep Link endpoint.
+
+Check lots of check boxes for serivices and data sharing.
+
+For a normal tool select "Allow the tool to be launched as a link"
+
+For a deep link tool select "Allow external tool to configure itself"
+
+Select LTI 1.3 near the bottom and provide both the Tools's OIDC endpoints.  Sakai only
+supports one of each endpoint, (i.e. you cannot enter a comma separated list of values).
+
+After you save the tool immediately view it.  Then you will see public keys, private keys, issuer,
+keyset endpoint, token endpoint, etc that you can copy into your tool.   
+
+If you want to use a different public / private key pair for communications from the tool to Sakai,
+you can edit the tool entry, delete the tool private key, and paste in your own tool public key.  Sakai
+does not yet support a keyset url for communications coming from the tool.
+

basiclti/basiclti-impl/src/bundle/ltiservice.properties

@@ -71,13 +71,13 @@ bl_allowoutcomes=Allow External Tool to return grades
 bl_allowlineitems=Allow External Tool to create grade columns
 bl_allowroster=Provide Roster to External Tool
 bl_allowsettings=Allow External Tool to store setting data
-bl_allowcontentitem=Allow External Tool to configure itself (the tool must support the IMS Content-Item message)
-pl_header=Indicate the following types of Content Item Selection launches this tool can handle.  Not all tools can handle Content Item Selection launches.  If you enable a tool which is not capable of responding to a particular request, it will likely fail when you try to use it.
+bl_allowcontentitem=Allow External Tool to configure itself (the tool must support the IMS Content-Item or Deep-Link message)
+pl_header=Indicate the following types of Content Item/Deep Link Selection launches this tool can handle.  Not all tools can handle types of launches.  If you enable a tool which is not capable of responding to a particular request, it will likely fail when you try to use it.
 bl_pl_launch=Allow the tool to be launched as a link (this is typically true for most tools)
-bl_pl_linkselection=Allow external tool to configure itself (the tool must support the IMS Content-Item message)
+bl_pl_linkselection=Allow external tool to configure itself (the tool must support the IMS Content-Item or Deep-Link message)
 bl_pl_importitem=Allow the tool to provide a common cartridge (usually to be imported into a tool like Lessons)
 bl_pl_fileitem=Allow the tool to provide a file (usually as part of a file picker)
-bl_pl_contenteditor=Allow the tool to be used from the rich content editor to select content (the tool must support the IMS Content-Item message)
+bl_pl_contenteditor=Allow the tool to be used from the rich content editor to select content (the tool must support the IMS Content-Item or Deep-Link message)
 bl_pl_assessmentselection=Allow the tool to be one of the assessment types
 bl_allowcustom=Allow additional custom parameters
 bl_custom=Custom Parameters (key=value on separate lines)

basiclti/basiclti-tool/src/webapp/vm/lti_tool_insert.vm

@@ -44,8 +44,8 @@ function checkRadioSettings() {
         var changed = false;
         if ( $("input[name='allowtitle']:checked").val() == 0 ||
              $("input[name='allowlaunch']:checked").val() == 0 ) {
-            $("#allowtitle_allow").click();
-            $("#allowlaunch_allow").click();
+            $("#allowtitle_allow-input").click();
+            $("#allowlaunch_allow-input").click();
             $( "#radioDialog" ).dialog();
         }
     }