Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better splinemodel #991

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better splinemodel #991

wants to merge 2 commits into from

Conversation

newville
Copy link
Member

@newville newville commented Feb 2, 2025

This explicitly implements the Spline model function, instead of overwriting SplineModel.eval(), so that a simple evaluation will work, which is more consistent and needed when loading a saved Model.

Description

This should solve #990

Type of Changes
  • Bug fix
  • New feature
  • Refactoring / maintenance
  • Documentation / examples
Tested on

Python: 3.12.8 | packaged by conda-forge | (main, Dec 5 2024, 14:25:12) [Clang 18.1.8 ]

lmfit: 1.3.2.post23+gec300195, scipy: 1.15.1, numpy: 1.26.4, asteval: 1.0.6, uncertainties: 3.2.2

Verification

Have you

  • included docstrings that follow PEP 257?
  • referenced existing Issue and/or provided relevant link to mailing list?
  • verified that existing tests pass locally?
  • verified that the documentation builds locally?
  • squashed/minimized your commits and written descriptive commit messages?
  • added or updated existing tests to cover the changes?
  • updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
  • added an example?

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.19%. Comparing base (54a119f) to head (ec8c1d8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   92.59%   93.19%   +0.59%     
==========================================
  Files          10       10              
  Lines        3836     3836              
==========================================
+ Hits         3552     3575      +23     
+ Misses        284      261      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@newville
Copy link
Member Author

newville commented Feb 5, 2025

any objections to merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant