Allow direct dispatch for the ObjFW runtime

[Midar]

Allow direct dispatch for the ObjFW runtime

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-clang-codegen

@llvm/pr-subscribers-clang

Author: Jonathan Schleifer (Midar)

Changes

There was no reason for it to ever be disabled.

---

Full diff: https://github.com/llvm/llvm-project/pull/126382.diff

1 Files Affected:

• (modified) clang/include/clang/Basic/ObjCRuntime.h (+1-1)

diff --git a/clang/include/clang/Basic/ObjCRuntime.h b/clang/include/clang/Basic/ObjCRuntime.h
index 1ccf60f0b7bee7..df42b438986111 100644
--- a/clang/include/clang/Basic/ObjCRuntime.h
+++ b/clang/include/clang/Basic/ObjCRuntime.h
@@ -473,7 +473,7 @@ class ObjCRuntime {
     case GCC: return false;
     case GNUstep:
       return (getVersion() >= VersionTuple(2, 2));
-    case ObjFW: return false;
+    case ObjFW: return true;
     }
     llvm_unreachable("bad kind");
   }

[Midar]

Would @rjmccall be the appropriate reviewer?

[Midar]

Also, would it be possible to get this into 20.1?

[Midar]

Actually, I realized this needs more work, as GenerateDirectMethodPrologue needs to be implemented. Moving to draft.

[Midar]

Copied the necessary parts from CGObjCMac to just ObjFW, as GNUstep decided to do it very differently.

Theoretically, the same could be done for the GCC runtime. Should it?