Skip to content

Commit

Permalink
[CSKY] Default to unsigned char
Browse files Browse the repository at this point in the history
This matches the ABI document found at
https://github.com/c-sky/csky-doc/blob/master/C-SKY_V2_CPU_Applications_Binary_Interface_Standards_Manual.pdf

Partially addresses #115957

Reviewed By: zixuan-wu

Pull Request: #115961
  • Loading branch information
arichardson authored Feb 9, 2025
1 parent e9a20f7 commit d204724
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions clang/lib/Driver/ToolChains/Clang.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1387,6 +1387,7 @@ static bool isSignedCharDefault(const llvm::Triple &Triple) {
return true;
return false;

case llvm::Triple::csky:
case llvm::Triple::hexagon:
case llvm::Triple::msp430:
case llvm::Triple::ppcle:
Expand Down
1 change: 1 addition & 0 deletions clang/test/Driver/csky-toolchain.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

// RUN: %clang -### %s --target=csky 2>&1 | FileCheck -check-prefix=CC1 %s
// CC1: "-cc1" "-triple" "csky"
// CC1: "-fno-signed-char"

// In the below tests, --rtlib=platform is used so that the driver ignores
// the configure-time CLANG_DEFAULT_RTLIB option when choosing the runtime lib
Expand Down

0 comments on commit d204724

Please sign in to comment.