Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag not working on touch devices. #186

Merged
merged 2 commits into from
Apr 7, 2024

Conversation

UtkarshSiddhpura
Copy link

No description provided.

@llaske
Copy link
Owner

llaske commented Apr 4, 2024

It's better but it's still very difficult to handle 😞

XT14x9Wju9

@UtkarshSiddhpura
Copy link
Author

@llaske did you make sure running these command as i updated the react-beautiful-dnd dependency

npm i -f
mkdir node_modules/lib
cp -r lib/* node_modules/lib
20240405-0658-07.7417238.mp4

@llaske
Copy link
Owner

llaske commented Apr 5, 2024

Yes I did it. I've even removed the whole node_modules directory.
Btw I'm not confident about the installation process since npm display a ton of error messages and it should be forced to work

@UtkarshSiddhpura UtkarshSiddhpura force-pushed the Drag-Issue-Touch-Devices branch from f50e92b to b947826 Compare April 5, 2024 10:25
@UtkarshSiddhpura
Copy link
Author

@llaske I tried fixing it by using css zoom property again (Revert)
We can't use zoom in word puzzle player as it'll cause double scroller and overflow,
It makes other templates overflow too, but they're supposed to have a vertical scrollbar, so it's fine.

@UtkarshSiddhpura
Copy link
Author

About npm install -f
we're facing version conflicts in our dependencies. Possibly someone updated dependencies or added new ones that are incompatible or not recommended.

@llaske llaske merged commit b947826 into llaske:master Apr 7, 2024
@llaske
Copy link
Owner

llaske commented Apr 7, 2024

Good job @UtkarshSiddhpura , it works now.

we're facing version conflicts in our dependencies. Possibly someone updated dependencies or added new ones that are incompatible or not recommended.

Sure! A cleaning work should be done. There is an issue #185

@UtkarshSiddhpura UtkarshSiddhpura deleted the Drag-Issue-Touch-Devices branch April 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants