Fix build warnings #561
Merged
Fix build warnings #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a few redundant generic-y statements. Signed-off-by: Octavian Purdila <[email protected]>
Implement a wrapper for the timer callback to fix the following
compile warning:
lib/posix-host.c:383:42: warning: cast between incompatible \
function types from ‘void (*)(void *)’ to ‘void (*)(union sigval)’ \
[-Wcast-function-type]
383 | .sigev_notify_function = (void (*)(union sigval))fn,
| ^
Signed-off-by: Octavian Purdila <[email protected]>
Add thread wrapper function. Fixes the following compile warning:
lib/posix-host.c: In function ‘thread_create’:
lib/posix-host.c:195:56: warning: cast between incompatible function \
types from ‘void (*)(void *)’ to ‘void * (*)(void *)’ [-Wcast-function-type]
195 | if (WARN_PTHREAD(pthread_create(&thread, NULL, (void* (*)(void *))fn, arg)))
| ^
lib/posix-host.c:77:41: note: in definition of macro ‘WARN_PTHREAD’
77 | #define WARN_PTHREAD(exp) _warn_pthread(exp, #exp)
| ^~~
Signed-off-by: Octavian Purdila <[email protected]>
This fixes a bunch of Wcast-function-type compile warnings:
arch/lkl/kernel/syscalls.c:27:35: warning: cast between incompatible function types from ‘long int (*)(pid_t, pid_t, int, long unsigned int, long unsigned int)’ {aka ‘long int (*)(int, int, int, long unsigned int, long unsigned int)’} to ‘long int (*)(void)’ [-Wcast-function-type]
27 | #define __SYSCALL(nr, sym) [nr] = (syscall_handler_t)sym,
| ^
./include/uapi/asm-generic/unistd.h:662:1: note: in expansion of macro ‘__SYSCALL’
662 | __SYSCALL(__NR_kcmp, sys_kcmp)
| ^~~~~~~~~
Signed-off-by: Octavian Purdila <[email protected]>
tavip
force-pushed
the
fix-build-warnings
branch
from
9ff627c to
75f1587
Compare
|
A little late here, sorry, but I think it should be possible to drop the extra heap alloc/free for posix timers by removing the unused callback parameter. I'll submit a new PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes a few (benign) build warnings that are triggered with new compilers.
Octavian Purdila (4):
lkl: fix redundant generic-y build warnings
lkl: posix: implement wrapper for timer callback
lkl: posix: add thread wrapper function
lkl: syscalls: use void pointers to store syscall handlers
arch/lkl/include/asm/Kbuild | 43 -------------------
arch/lkl/include/uapi/asm/Kbuild | 1 -
arch/lkl/kernel/syscalls.c | 11 ++---
tools/lkl/lib/posix-host.c | 74 +++++++++++++++++++++++++-------
4 files changed, 65 insertions(+), 64 deletions(-)