Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile errors #544

Closed
wants to merge 1 commit into from
Closed

fix compile errors #544

wants to merge 1 commit into from

Conversation

iacore
Copy link

@iacore iacore commented Jun 24, 2024

No description provided.

@ddiss
Copy link

ddiss commented Jun 27, 2024

Thanks for the PR. Please update the commit message to include:

  • details of the compiler version, architecture and error you're seeing
  • a sign off, as per Sign your work - the Developer's Certificate of Origin in submitting-patches.rst

Also, please ensure that checkpatch passes against your change.

As for the code change itself, I don't really see why the new cast is necessary: __pa() would cast the addresses back to a unsigned long type.

@iacore iacore closed this Jun 27, 2024
@iacore
Copy link
Author

iacore commented Jun 27, 2024

* details of the compiler version, architecture and error you're seeing

gcc (GCC) 14.1.1 20240522

arch: N/A

the error is just gcc doesn't let me compile the code with -Wall.

* a sign off, as per `Sign your work - the Developer's Certificate of Origin` in submitting-patches.rst

Also, please ensure that checkpatch passes against your change.

As for the code change itself, I don't really see why the new cast is necessary: __pa() would cast the addresses back to a unsigned long type.

sorry, i don't have time for this. you get the idea from the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants