Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for dashes in validator names #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/property_validator.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# ------------------

module.exports = class PropertyValidator
termRegex = /\w[\w ]*\w/g
termRegex = /[^, ][^,]*[^, ]/g
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe. that works for everything...
except for validator names that consist of a single char ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode validator names are working 😄
'😄,foobar'.match(/[^, ][^,]*[^, ]/g)


# @params
# - inputString { String } Validation String. E.g. 'string, optional'
Expand Down
17 changes: 17 additions & 0 deletions test/specs/jscheme_spec.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,23 @@ describe 'jscheme', ->
expect(isValid).to.equal(false)


describe 'a validator with dashes in its name', ->

beforeEach ->
@schema.add 'validator-with-a-dash', (value) ->
value == 'valid'

@schema.add 'template',
test: 'validator-with-a-dash'


it 'the validator is recognized', ->
isValid = @schema.validate 'template',
test: 'valid'

expect(isValid).to.equal(true)


describe 'a schema with a nested type', ->

beforeEach ->
Expand Down