Skip to content

Commit

Permalink
Add the first round of jest tests to CI, filtered out during iteration (
Browse files Browse the repository at this point in the history
#223)

- Add CI for wasm transplant tests, commented out for now. 
- Add fixes for several bugs reveal by wasm trasnplant tests.
  • Loading branch information
mobile-bungalow authored Nov 6, 2024
1 parent 6be58c6 commit 5bed2db
Show file tree
Hide file tree
Showing 10 changed files with 482 additions and 205 deletions.
21 changes: 16 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
toolchain: ${{ env.CARGO_MAKE_TOOLCHAIN }}
targets: wasm32-unknown-unknown

- name: Builb wasm
- name: Build wasm
run: cargo build --target wasm32-unknown-unknown -p liveview_native_core_wasm

- uses: taiki-e/install-action@v2
Expand All @@ -74,13 +74,24 @@ jobs:
with:
tool: wasm-bindgen

- name: Builb wasm for nodesjs
- name: Build wasm for nodesjs
working-directory: ./crates/wasm
run: ./build.sh nodejs
run: ./scripts/build.sh nodejs

- name: Builb wasm for web
- name: Build wasm for web
working-directory: ./crates/wasm
run: ./build.sh web
run: ./scripts/build.sh web

- name: Run Jest tests with wasm artifacts
working-directory: ./crates/wasm
run: |
if ./scripts/jest_tests.sh; then
echo "The wasm tests should not yet be passing."
echo "If core is now compliant, then remove this conditional."
exit 1
else
exit 0
fi
clippy:
runs-on: ubuntu-24.04
Expand Down
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,8 @@ xcode-build/
### From `cargo make uniffi-swift-tests
Package.resolved
.build

### from wasm builds and tests
crates/wasm/phoenix_live_view
crates/wasm/liveview-native-core-wasm-*
crates/wasm/liveview-native-core-wasm-*.tgz
68 changes: 34 additions & 34 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5bed2db

Please sign in to comment.