-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for compiling with multiple deps in content config #88
base: main
Are you sure you want to change the base?
Conversation
Can you add a test for this, we use |
Sure thing, though I'd have to add something like |
I should note that the stylesheet module is also in a dependency itself in our case. |
Added the config |
@mayel can you give me a bit more background in that case, what exactly is failing that requires this change? |
|
Oh I see, this is a compilation order issue then. So in that case your PR just ignores the error it doesn't fix the underlying issue of discovering those paths. |
Couldn't we just provide a list of patterns, relative to the CWD, instead of specifying otp_aps though? |
In your case you could if you'd like, you can simply just provide a list of relative paths |
@mayel can you confirm that the relative paths worked for your need? I don't think this needs to be merged if so |
Solves a compilation error when trying to put this in config: