Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #199

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Update readme #199

merged 6 commits into from
Aug 12, 2024

Conversation

BrooklinJazz
Copy link
Contributor

@BrooklinJazz BrooklinJazz commented Aug 12, 2024

Small additions to the README to clarify:

  • How to get the latest versions
  • What the native clients are and how to get started with them

README.md Outdated

## Native Clients

LiveView Native enables native client frameworks such as the [LiveView Native SwiftUI Client](https://github.com/liveview-native/liveview-client-swiftui) and the [LiveView Native Jetpack Client (In Progress)](https://github.com/liveview-native/liveview-client-jetpack).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have a matrix of clients that we're listing include the html client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me, but I'm not sure how you want that to look as a matrix 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a table maybe?

UI Framework Devices, LiveView Client
SwiftUI iPhone, iPad, AppleTV, Apple Watch, MacOS, Apple Vision Pro LiveView Native SwiftUI
JetPack Compose Android family LiveView Native Jetpack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a list of all of them. Let me know if that's not what you have in mind and how to improve it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the table above, let's go with that. You should be able to copy/paste that in and just add a HTML one as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BrooklinJazz ☝️ can you change to the table form?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, sorry there was a desync issue when I asked the question so I hadn't seen the table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated

### SwiftUI Client

To create your first LiveView Native LiveView, go to the [LiveView Native SwiftUI Client Usage](https://github.com/liveview-native/liveview-client-swiftui?tab=readme-ov-file#usage) guide on GitHub. Alternatively, you can read the [LiveView Native SwiftUI Documentation] where you can find documentation, examples, and interactive Livebook guides.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why we need to include client-specific sections in here, that's for those docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was it's not immediately obvious to someone new to LVN that these client libraries exist, or where to find resources for them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think the client matrix noted above should cover that. We can just link out to them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed them, but kept a list referencing them to improve discoverability.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries :)

@bcardarella
Copy link
Contributor

Thanks!

@bcardarella bcardarella merged commit ab55865 into main Aug 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants