Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split logs combined by stdout, support dev #996

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Split logs combined by stdout, support dev #996

merged 3 commits into from
Mar 3, 2025

Conversation

frostbyte73
Copy link
Member

No description provided.

@frostbyte73 frostbyte73 requested review from a team March 3, 2025 10:39
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 9cd638a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@frostbyte73 frostbyte73 merged commit c4a3f3c into main Mar 3, 2025
7 checks passed
continue
case strings.HasPrefix(line, "turnc"):
// warn on turnc error
l.logger.Infow(line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this meant to be a Warnw?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just forgot to change the comment. It was originally warnw but got reduced

@frostbyte73 frostbyte73 deleted the log-split branch March 3, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants