LightGBM v4 #32
Open
LightGBM v4 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves #33 I am using a slightly simpler switch than in "shapviz" in order to keep the code clean: If lgb has version >= 4, then use the new |
jameslamb
reviewed
Jul 19, 2022
R/SHAP_funcs.R
Outdated
| (X_train), | ||
| predcontrib = TRUE) | ||
| # New predict() interface for LGB 4 | ||
| if (inherits(xgb_model, "lgb.Booster") && utils::packageVersion("lightgbm") >= 4) { |
There was a problem hiding this comment.
@mayer79 for your consideration.... using >= 4 means that the wrong decision will be made when testing against the current development version of {lightgbm} built from source, where the version is 3.3.2.99.
To work around that, in tidymodels/bonsai#42 I did the following:
using_newer_lightgbm_version <- function(){
utils::packageVersion("lightgbm") > package_version("3.3.2")
}There was a problem hiding this comment.
That is clearly better, thanks for pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open PR changing the predict() interface of LightGBM:
microsoft/LightGBM#5133
We should wait with merging this PR here until the LGB PR is accepted and the upcoming LGB version is clear.