Address comment to make getMetadataSize abstract in the base class

liuml07 · Dec 5, 2024 · cbc8c74 · cbc8c74
1 parent 9cdbb12
commit cbc8c74
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java
@@ -93,10 +93,8 @@ public abstract class AbstractCheckpointStats implements Serializable {
      */
     public abstract long getCheckpointedSize();
 
-    /** @return The metadata file size, 0 if unknown. */
-    public long getMetadataSize() {
-        return 0;
-    }
+    /** @return The metadata file size. */
+    public abstract long getMetadataSize();
 
     /** @return the total number of processed bytes during the checkpoint. */
     public abstract long getProcessedData();

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java b/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpointStats.java
@@ -155,6 +155,11 @@ public long getStateSize() {
         return currentStateSize;
     }
 
+    @Override
+    public long getMetadataSize() {
+        return 0;
+    }
+
     @Override
     public long getCheckpointedSize() {
         return currentCheckpointedSize;

diff --git a/.../src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java b/.../src/test/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointStatsTrackerTest.java
@@ -402,7 +402,7 @@ public void addSpan(SpanBuilder spanBuilder) {
         pending.reportSubtaskStats(jobVertexID, createSubtaskStats(0, true));
 
         // Complete checkpoint => new snapshot
-        tracker.reportCompletedCheckpoint(pending.toCompletedCheckpointStats(null));
+        tracker.reportCompletedCheckpoint(pending.toCompletedCheckpointStats(null, 1984));
 
         assertThat(reportedSpans.size()).isEqualTo(1);
         reportedSpan = Iterables.getOnlyElement(reportedSpans);