Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [fix] Fix a bug of not-localized About view #302

Merged
merged 1 commit into from
Apr 17, 2021
Merged

🐛 [fix] Fix a bug of not-localized About view #302

merged 1 commit into from
Apr 17, 2021

Conversation

juggernautjp
Copy link
Contributor

I fixed a bug for the issue #301.

Not fixed bugs

I can not the following two bugs. Need help.

1. After click the "Check now" button

  1. Select [File] -> [Settings]
  2. Click [Packages] in the "Settings" view
  3. Click "Setting"in the "atom-i18n" package
  4. Select "日本語 (ja)" as "Language" item
  5. Click "Atom について" (en: "About Atom") tab
  6. Click "更新を今すぐ確認" (en: "Check now") button, which is the right side of "Atom は最新の状態です!" (en: "Atom is up to date!")
  7. The, localized "Atom は最新の状態です!" is replaced with "Atom is up to date!"
  8. Also, "Checking for updates..." is shown, instead of localized message, "更新を確認しています...", wchich is defined in ja/about.cson

2. "Show more" and "Hide" button

"Show more" and "Hide" message are not localized, because I do not know how to handle the click event.

Not tested

I do not test the following message, because I do not know the steps to create the environment that Atom need to update.

About:
  restartInstall: "Restart and install"

@juggernautjp juggernautjp requested a review from liuderchi as a code owner March 29, 2021 05:46
Copy link
Owner

@liuderchi liuderchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🙇‍♂️

@liuderchi liuderchi merged commit 5ba82df into liuderchi:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants