chore: add TLS configs for keycloak #616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltmcnealy-lh
approved these changes
Jan 19, 2024
| *) | ||
| fi | ||
|
|
||
| if [ ${kafka} = true ]; then |
There was a problem hiding this comment.
Please let's not do this, there is no use-case for setting up without kafka.
|
This change modify the setup script for configuring keycloak with TLS and that way the dashboard can work @diablouma please test the dashbord pointing to both And let me know if the change is needed In case the dashboard work without TLS maybe this is not needed |
|
NOT NEEDED, master works well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@diablouma please test over this branch the dashboard, remember to point to https://localhost:8443