More GRPC Docs #611
Merged
More GRPC Docs #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltmcnealy-lh
requested review from
mijailr,
diablouma,
sauljabin,
eduwercamacaro and
MateoRojas
coltmcnealy-lh
commented
Jan 17, 2024
| @@ -327,7 +327,7 @@ export type Exact<P, I extends P> = P extends Builtin ? P | |||
|
|
|||
| function toTimestamp(dateStr: string): Timestamp { | |||
| const date = new globalThis.Date(dateStr); | |||
| const seconds = date.getTime() / 1_000; | |||
| const seconds = Math.trunc(date.getTime() / 1_000); | |||
There was a problem hiding this comment.
Why is this changed? Did someone change the protoc version?
coltmcnealy-lh
commented
Jan 17, 2024
| @@ -1016,7 +1016,7 @@ export type Exact<P, I extends P> = P extends Builtin ? P | |||
|
|
|||
| function toTimestamp(dateStr: string): Timestamp { | |||
| const date = new globalThis.Date(dateStr); | |||
| const seconds = date.getTime() / 1_000; | |||
| const seconds = Math.trunc(date.getTime() / 1_000); | |||
There was a problem hiding this comment.
This looks like a protoc version change. Weird. @sauljabin any ideas?
Co-authored by: Eduwer Camacaro <[email protected]>
|
Team, this is ready to go. @eduwercamacaro remember when we were on zoom, we made a small change to I reverted that change, so this PR is strictly a docs PR. But we need to fix that. |
eduwercamacaro
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.