Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): explicitly state none found #1328

Merged
merged 5 commits into from
Feb 23, 2025
Merged

fix(dashboard): explicitly state none found #1328

merged 5 commits into from
Feb 23, 2025

Conversation

bryson-g
Copy link
Contributor

@bryson-g bryson-g commented Feb 22, 2025

resolves #1293

  • The previous implementation only checked if pages.length == 0, which did not accurately display when there were no search results found. This is because the pages object is the type of SearchResponse[], and at least one SearchResponse object will always be populated in the array, so it would never == 0. The more accurate implementation would be to check if ?.results.length == 0 for every response within the array.

@bryson-g bryson-g merged commit 63d70a8 into master Feb 23, 2025
24 checks passed
@bryson-g bryson-g deleted the issue-1293 branch February 23, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard: explicitly state no sources found
2 participants