Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canary): add grpc code status to canary metrics #1324

Merged
merged 13 commits into from
Feb 25, 2025
Merged

fix(canary): add grpc code status to canary metrics #1324

merged 13 commits into from
Feb 25, 2025

Conversation

sauljabin
Copy link
Member

@sauljabin sauljabin commented Feb 21, 2025 •
edited
Loading

It includes:

  • Refactor in main class
  • Refactor in web services class
  • Refactor in metronome Beat and BeatStatus classes
  • Refactor in kafka producer
  • Add config WorkflowRetention
  • Add status and reason tags
  • Change exhausted retries metric to GET_WF_RUN_REQUEST with status=ERROR and reason=EXHAUSTED_RETRIES
  • Change MetricKey.id to MetricKey.name
  • Change lh.canary.metronome.run.sample.rate to lh.canary.metronome.run.sample.percentage
  • Remove LHClient metric (not used)
  • Remove org.jetbrains.annotations.NotNull

Screenshot from 2025-02-24 16-56-54
Screenshot from 2025-02-24 17-00-32

@mijailr
Copy link
Contributor

mijailr commented Feb 21, 2025

We can test the branch on staging if you want to give it a try.

@sauljabin sauljabin requested a review from mijailr February 21, 2025 17:01
@sauljabin
Copy link
Member Author

Waiting for new improvements

mijailr
mijailr requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mijailr mijailr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to add reason label to the metric and keep the grouping OK, ERROR

@sauljabin sauljabin marked this pull request as draft February 21, 2025 22:27
@sauljabin sauljabin self-assigned this Feb 21, 2025
@sauljabin sauljabin added the canary Affects the LittleHorse Canary label Feb 21, 2025
@sauljabin sauljabin requested a review from mijailr February 24, 2025 22:16
@sauljabin sauljabin marked this pull request as ready for review February 24, 2025 22:16
@sauljabin
Copy link
Member Author

Waiting for @eduwercamacaro to review

@sauljabin sauljabin mentioned this pull request Feb 25, 2025
Open
@sauljabin sauljabin merged commit a11ac46 into master Feb 25, 2025
24 checks passed
@sauljabin sauljabin deleted the fix/distinguish-canary-error-and-wfstatus branch February 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduwercamacaro eduwercamacaro eduwercamacaro approved these changes

@mijailr mijailr mijailr approved these changes

@MateoRojas MateoRojas Awaiting requested review from MateoRojas

@coltmcnealy-lh coltmcnealy-lh Awaiting requested review from coltmcnealy-lh

Assignees

@sauljabin sauljabin

Labels
canary Affects the LittleHorse Canary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sauljabin @mijailr @eduwercamacaro