Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use monorepo tools #12

Merged
merged 4 commits into from
Nov 16, 2024
Merged

refactor: use monorepo tools #12

merged 4 commits into from
Nov 16, 2024

Conversation

hazimoarafa
Copy link
Member

@hazimoarafa hazimoarafa commented Nov 16, 2024 •
edited
Loading

closes #6

  • use npm workspaces
  • updated all CI/CD to accommodate new mono repo tools
  • add lint script to /api-client to check for lint errors
  • add dev script to /api-client which means live code changes when working on /ui

@hazimoarafa hazimoarafa force-pushed the refactor/implement-mono-repo branch 3 times, most recently from bc2462d to fd8555b Compare November 16, 2024 01:13
@hazimoarafa hazimoarafa force-pushed the refactor/implement-mono-repo branch from fd8555b to cbcdb1c Compare November 16, 2024 01:20
@hazimoarafa hazimoarafa requested a review from mijailr November 16, 2024 01:24
@hazimoarafa hazimoarafa assigned sauljabin and unassigned sauljabin Nov 16, 2024
@hazimoarafa hazimoarafa force-pushed the refactor/implement-mono-repo branch from 33aa040 to c94b411 Compare November 16, 2024 02:10
@hazimoarafa hazimoarafa mentioned this pull request Nov 16, 2024
Merged
@hazimoarafa hazimoarafa linked an issue Nov 16, 2024 that may be closed by this pull request
Run api pipeline when merging to main branch #2
Closed
@hazimoarafa hazimoarafa mentioned this pull request Nov 16, 2024
Closed
sauljabin
sauljabin approved these changes Nov 16, 2024
View reviewed changes
.github/workflows/publish.yml
@@ -26,4 +26,4 @@ jobs:
- name: Publish
run: npm publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but I guess this is going to fail, anyway we can merge it and fix it in due time, It's more important to have the main pipeline

@sauljabin sauljabin merged commit 8daece6 into main Nov 16, 2024
1 check passed
@sauljabin sauljabin deleted the refactor/implement-mono-repo branch November 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauljabin sauljabin sauljabin approved these changes

@mijailr mijailr Awaiting requested review from mijailr

@muhammadqamar muhammadqamar Awaiting requested review from muhammadqamar

@jhosep-marin jhosep-marin Awaiting requested review from jhosep-marin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use monorepo tools Run api pipeline when merging to main branch
2 participants
@hazimoarafa @sauljabin