Patch to work with current YouTube #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 12, 2020 02:52
…ation for merge request
|
Thank you for the PR and for updating the regex! Really grateful for it as I haven't had time to update this module while working on other projects. I'll look into getting this thoroughly reviewed, merged, and tested in the coming few days - apologies if this is something you want to be merged ASAP. |
|
Feel free to take your time. I updated the imports in my personal projects to use my fork for the time being. The regex for the player config on the embed page sadly also isn't that great which is which is why I then continue to further split the string (which is more of a dirty hack than anything) |
|
This pull request was made 3 years ago and it was never merged |
|
Up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some changes on YouTube's end, youtube.Load() would always fail as it didn't find anything matching on the old regular expressions.
These changes make the library work again with YouTube as of 13th of December 2020