Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(debugger): passing debugger to app #3967

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(debugger): passing debugger to app #3967

wants to merge 18 commits into from
+116 −5

Conversation

oek1ng
Copy link
Contributor

@oek1ng oek1ng commented Jan 23, 2025

Description

Passing debugger_module variable to app

  • Added type for pdb-like module, which supports post_mortem method
  • Added debugger test app
  • Added doc

Closes

#3949

Alexandr Panteleev added 15 commits January 22, 2025 10:23
feat: add customizable debugger module for exception handling
674b0ab
feat(debug): introduce debugger type protocols for enhanced exception…
d666ba6 
… handling
feat(debug): update debugger module references to use Debugger type
2097919
refactor(debug): reorganize imports and improve type aliasing in debu…
e5fb4ef 
…gger types
chore(pre-commit): update exclude pattern to include debugging test f…
2ce9545 
…iles
refactor(debug): moved test debug app into a directory
36b5ae5
chore(pre-commit): update exclude patterns for debugging and codespel…
4cf211a 
…l hooks
docs(debug): add section on configuring Litestar with advanced Python…
79ccec4 
… debuggers
docs(debug): enhance section on configuring Litestar with default deb…
0498666 
…ugging tool
docs(debug): fix formatting for default pdb reference in debugging do…
c9cecdb 
…cumentation
fix(debug): include ModuleType in Debugger type alias for enhanced ty…
4d6b8da 
…pe support
fix(debug): import Debugger type from debugger_types for improved typ…
b8aec1a 
…e support
fix(debug): update debugger module docstring to clarify support for p…
14b0de1 
…ost_mortem() protocol
fix(debug): update debugger_module docstring to clarify support for p…
7f0b722 
…ost_mortem() protocol
fix(debug): remove redundant Debugger import from type checking and u…
5f86bfe 
…pdate import statements
@oek1ng oek1ng requested review from a team as code owners January 23, 2025 08:01
@github-actions github-actions bot added area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API area/types This PR involves changes to the custom types size: small pr/external Triage Required 🏥 This requires triage labels Jan 23, 2025
@oek1ng oek1ng changed the title Passing debugger to app feat(debugger): passing debugger to app Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (f2da7ed) to head (c0e52be).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3967   +/-   ##
=======================================
  Coverage   98.34%   98.35%           
=======================================
  Files         347      348    +1     
  Lines       15743    15768   +25     
  Branches     1740     1741    +1     
=======================================
+ Hits        15483    15508   +25     
  Misses        124      124           
  Partials      136      136

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

oek1ng
oek1ng commented Jan 23, 2025
View reviewed changes
litestar/types/debugger_types.py
) -> Optional[NoReturn]: ...


Debugger: TypeAlias = Union[ModuleType, PDBProtocol, IPDBProtocol, PDBRProtocol, PUDBProtocol]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that

@github-actions github-actions bot added area/dependencies This PR involves changes to the dependencies and removed size: small labels Jan 23, 2025
@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dependencies This PR involves changes to the dependencies area/docs This PR involves changes to the documentation area/private-api This PR involves changes to the privatized API area/types This PR involves changes to the custom types pr/external size: medium Triage Required 🏥 This requires triage type/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oek1ng