Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure external network #1694

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Configure external network #1694

merged 1 commit into from
Mar 21, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Feb 28, 2023 •
edited
Loading

Description

This pr makes it possible to configure the external network module.

Ref #1671

How Has This Been Tested?

  • locally on KinD

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Feb 28, 2023

/build

@aleoli aleoli force-pushed the aol/configure-external-network branch from 61bbb6a to 17da790 Compare March 1, 2023 08:56
@aleoli
Copy link
Member Author

aleoli commented Mar 1, 2023

/build

@aleoli aleoli force-pushed the aol/configure-external-network branch from f846618 to 877d0b9 Compare March 1, 2023 10:42
@aleoli
Copy link
Member Author

aleoli commented Mar 8, 2023

/build

@aleoli aleoli force-pushed the aol/configure-external-network branch from 877d0b9 to 321c706 Compare March 16, 2023 08:08
@aleoli aleoli mentioned this pull request Mar 16, 2023
Open
10 tasks
@aleoli aleoli force-pushed the aol/configure-external-network branch 2 times, most recently from f977dab to 48755e6 Compare March 20, 2023 08:04
@pull-request-size pull-request-size bot added size/M and removed size/L labels Mar 20, 2023
@aleoli aleoli force-pushed the aol/configure-external-network branch from 48755e6 to 9ceb974 Compare March 20, 2023 08:09
@aleoli
Copy link
Member Author

aleoli commented Mar 20, 2023

/test

@aleoli aleoli requested a review from cheina97 March 20, 2023 08:52
@aleoli aleoli marked this pull request as ready for review March 20, 2023 08:52
@aleoli
Copy link
Member Author

aleoli commented Mar 21, 2023

/rebase test=true

@adamjensenbot adamjensenbot force-pushed the aol/configure-external-network branch from 9ceb974 to 73b9919 Compare March 21, 2023 10:38
@aleoli
Copy link
Member Author

aleoli commented Mar 21, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 21, 2023
@adamjensenbot adamjensenbot merged commit 2544b85 into liqotech:master Mar 21, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 21, 2023
@p-linnane p-linnane mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @cheina97