Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VK: configurable network condition #1685

Merged
merged 1 commit into from
Mar 15, 2023
Merged

VK: configurable network condition #1685

merged 1 commit into from
Mar 15, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Feb 22, 2023 •
edited
Loading

Description

This pr adds the possibility to disable the network condition check to set the node to ready

Ref #1671

How Has This Been Tested?

  • locally on KinD

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli mentioned this pull request Feb 22, 2023
Open
10 tasks
@aleoli
Copy link
Member Author

aleoli commented Feb 22, 2023

/build

@aleoli aleoli force-pushed the aol/configurable-network-condition branch from a8d1a30 to 280247d Compare February 22, 2023 09:58
@aleoli
Copy link
Member Author

aleoli commented Feb 22, 2023

/test

@aleoli aleoli force-pushed the aol/configurable-network-condition branch from 280247d to 40aaba7 Compare February 22, 2023 10:27
@aleoli
Copy link
Member Author

aleoli commented Feb 22, 2023

/test

@aleoli aleoli added kind/feature hold Prevent bot merging labels Feb 22, 2023
@aleoli aleoli force-pushed the aol/configurable-network-condition branch from 40aaba7 to b01adc1 Compare February 23, 2023 09:32
@aleoli aleoli force-pushed the aol/configurable-network-condition branch from b01adc1 to c111cf3 Compare March 15, 2023 10:34
@aleoli aleoli removed the hold Prevent bot merging label Mar 15, 2023
@aleoli
Copy link
Member Author

aleoli commented Mar 15, 2023

/test

@aleoli aleoli requested a review from cheina97 March 15, 2023 13:22
@aleoli aleoli marked this pull request as ready for review March 15, 2023 13:23
@cheina97
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 15, 2023
@adamjensenbot adamjensenbot merged commit 861ce95 into liqotech:master Mar 15, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 15, 2023
@p-linnane p-linnane mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @cheina97