Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to configure IPAM module #1673

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Make it possible to configure IPAM module #1673

merged 1 commit into from
Mar 15, 2023

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Feb 16, 2023 •
edited
Loading

Description

This pr allows the Liqo users to use different IPAM modules (implementing the Liqo APIs) or to disable the IPAM completely, also disabling the IP translation between the two clusters (this may be useful in case of not overlapping pod CIDRs with an external network layer)

Ref #1671

How Has This Been Tested?

  • locally on KinD with the Liqo network module enabled
  • locally on KinD without the IP translation

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli
Copy link
Member Author

aleoli commented Feb 16, 2023

/build

1 similar comment
@aleoli
Copy link
Member Author

aleoli commented Feb 16, 2023

/build

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 21, 2023
@aleoli
Copy link
Member Author

aleoli commented Feb 21, 2023

/build

@aleoli
Copy link
Member Author

aleoli commented Feb 21, 2023

/test

@aleoli
Copy link
Member Author

aleoli commented Feb 21, 2023

/test

@aleoli aleoli mentioned this pull request Feb 21, 2023
Open
10 tasks
@aleoli aleoli changed the title Make it possible to disable IPAM module Make it possible to configure IPAM module Feb 21, 2023
@aleoli aleoli marked this pull request as ready for review February 21, 2023 16:51
@aleoli aleoli requested a review from cheina97 February 21, 2023 16:51
@aleoli aleoli added kind/feature hold Prevent bot merging labels Feb 22, 2023
@aleoli
Copy link
Member Author

aleoli commented Feb 24, 2023

/test

@aleoli aleoli removed the hold Prevent bot merging label Mar 15, 2023
@aleoli
Copy link
Member Author

aleoli commented Mar 15, 2023

/rebase test=true

@aleoli
Copy link
Member Author

aleoli commented Mar 15, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Mar 15, 2023
@adamjensenbot adamjensenbot merged commit 4133f4d into liqotech:master Mar 15, 2023
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Mar 15, 2023
@p-linnane p-linnane mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheina97 cheina97 cheina97 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aleoli @adamjensenbot @cheina97