Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maps/react: fix react map namespaces #1766

Merged
merged 1 commit into from
Jan 29, 2025
Merged

maps/react: fix react map namespaces #1766

merged 1 commit into from
Jan 29, 2025

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Jan 29, 2025 •
edited
Loading

fixes map namespace clash with react_maps

mb PR: liqd/a4-meinberlin#6003

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@vellip vellip requested a review from goapunk January 29, 2025 15:20
@vellip vellip mentioned this pull request Jan 29, 2025
Merged
5 tasks
@vellip vellip force-pushed the pv-2025-01-fix-map-namespaces branch from 2707e62 to 897c879 Compare January 29, 2025 15:31
goapunk
goapunk approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@goapunk goapunk merged commit b02d6d3 into main Jan 29, 2025
5 checks passed
@goapunk goapunk deleted the pv-2025-01-fix-map-namespaces branch January 29, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vellip @goapunk