[#8826] cms/how-to-take-part: add how to take part block #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hom3mad3
requested changes
Feb 3, 2025
There was a problem hiding this comment.
In this class, HowToTakePartBlock, the name is currently focused on the use case rather than the elements. To make the naming more aligned with the structural elements and provide better flexibility for future use cases, we should consider a name that reflects the block's structural components.
vellip
force-pushed
the
pv-2025-01-how-to-take-part-block
branch
from
05ccb34 to
cb40a0e
Compare
vellip
force-pushed
the
pv-2025-01-how-to-take-part-block
branch
from
cb40a0e to
42bce21
Compare
hom3mad3
reviewed
Feb 5, 2025
| icon = "image" | ||
|
|
||
|
|
||
| class ColoredPanelsBlock(blocks.StructBlock): |
There was a problem hiding this comment.
Thanks for the update—this is definitely better! However, I think we should consider adding icon list somewhere, since we're not passing anything else to this block. That might help clearly represent its purpose in the CMS. Sorry if my previous review was unclear or misleading 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add how to take part block to cms and remove unused ImageCallToActionBlock
Tasks