Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type code renewal #135

Closed
wants to merge 17 commits into from
Closed

Type code renewal #135

wants to merge 17 commits into from

Conversation

vharmain
Copy link
Contributor

@vharmain vharmain commented Oct 28, 2024

Larger changes to sports site categorization. The changes have been prepared since 2022 and approved by the LIPAS steering committee.

  • a few new type-codes
  • a few old types merged
  • a few new property types
  • property overhaul for many types

All the changes are "implemented" in types_new.cljc and the resulting categorization is inlined in types.cljc. The starting point was left untouched and renamed as types_old.cljc.

Similarly property type changes: prop_types_new.cljc, prop_types_old.cljc and prop_types.cljc.

*_old and *_new namespaces can be removed later, once we're sure we don't miss anything from them.

TODO:

  • Verify all new props have specs
  • Fix formatting to accommodate cljfmt
  • Prepare winter/summer use data migration to the new year-round-use prop
  • Verify legacy integration doesn't blow up with new types & props
  • Wait for approval to release in prod (can be merged silently, but then "old types" and "old prop types" need to be "enabled" to hide the changes)

@vharmain vharmain marked this pull request as draft October 28, 2024 20:15
@vharmain vharmain changed the title Draft: Type code renewal Type code renewal Oct 28, 2024
@vharmain vharmain force-pushed the type-code-renewal-2 branch 2 times, most recently from 4493274 to c5e6c65 Compare October 30, 2024 20:20
@vharmain vharmain force-pushed the type-code-renewal-2 branch from c5e6c65 to 7a90d1f Compare October 31, 2024 18:14
@vharmain vharmain closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant