fix: Orient exterior rings counter-clockwise TDE-1205 #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
force-pushed
the
fix/counter-clockwise-outer-ring
branch
4 times, most recently
from
85b7f9d to
2f6e37f
Compare
l0b0
force-pushed
the
fix/counter-clockwise-outer-ring
branch
4 times, most recently
from
8f7060d to
b98e3cb
Compare
amfage
force-pushed
the
fix/counter-clockwise-outer-ring
branch
from
b98e3cb to
8f6fdb7
Compare
l0b0
force-pushed
the
fix/counter-clockwise-outer-ring
branch
from
8f6fdb7 to
29a170f
Compare
We load the item from a JSON file into a `dict` in the production code, but none of our automated tests verify this code path, so it broke. This partially reverts commit ed177c6.
[GeoJSON requires this](https://datatracker.ietf.org/doc/html/rfc7946#section-3.1.6): > A linear ring MUST follow the right-hand rule with respect to the area > it bounds, i.e., exterior rings are counterclockwise, and holes are > clockwise. However, [Shapely does not do this by default](shapely/shapely#622).
l0b0
force-pushed
the
fix/counter-clockwise-outer-ring
branch
from
29a170f to
fb6adcf
Compare
amfage
approved these changes
Jun 21, 2024
|
Superseded by #1008 to specify counter-clockwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #993.
Motivation
GeoJSON requires this:
However, Shapely does not do this by default.
Closes linz/elevation#298 (but we'll have to reprocess datasets to get the right geometry).
Before: capture-area.geojson
After: capture-area.geojson
Example from Hawke's Bay 2023 Elevation dataset:
Before:
capture-area.hb.before.zip
After:
capture-area.hb.after.zip
Modification
Reverse merged polygon orientation.
Checklist