Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle optional flags from Argo TDE-1346 #1287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amfage
Copy link
Contributor

@amfage amfage commented Feb 17, 2025

Motivation

Argo Workflows supplies single quotes where parameters are not supplied, which can happen if a workflow template is used by multiple workflows. This breaks optional parameters in argparse.

Modifications

Convert Argo string to boolean to control adding the capture dates file and the title suffix, in line with how the capture area creation (footprint) is handled.

Verification

Ran workflow in Argo and locally on the command line.

@amfage amfage added the container Publish a container label Feb 17, 2025
@amfage amfage added container Publish a container and removed container Publish a container labels Feb 19, 2025
@amfage amfage marked this pull request as ready for review February 20, 2025 02:16
@amfage amfage requested a review from a team as a code owner February 20, 2025 02:16
Copy link
Collaborator

@paulfouquet paulfouquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some tests for these utility functions part of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Publish a container
Development

Successfully merging this pull request may close these issues.

2 participants