A number of cleanup patches #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the deprecated `meson builddir`
We could move this into the respective default: case of the switch statement below but then we won't get compiler warnings about missing enum values. So let's add this to have a clean scan-build output.
Instead of duplicating the code here build the default Styli= entry and parse it as if it were set by the tablet file.
Ensure the memcmp works on the array element size without having to remember what exactly that was.
Use g_hash_table_add() to treat it like a set and then copy that over into a GArray.
Slightly improved code-hygiene, we can afford an extra pointer so we don't accidentally re-use a variable. And g_clear_pointer() resets everything to NULL so re-using it will blow up instead of giving us invalid values.
Instead of
if (string_list) {
for (....) {
Do this
for (...; string_list && ...) {
We can move the string_list != NULL check into the for loop. And use
g_clear_pointer() to ensure our pointer is NULL in case we accidentally
re-use it.
No functional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep work for other patches, might as well get those out