Id and group modifications #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID, 0x40200, is not used in any Wacom product. This change removes the ID. Signed-off-by: Tatsunosuke Tobita <[email protected]> Signed-off-by: Tatsunosuke Tobita <[email protected]>
Since Movink supports mobilestudio and propengen2 groups, they are added by this change. Signed-off-by: Tatsunosuke Tobita <[email protected]> Signed-off-by: Tatsunosuke Tobita <[email protected]
|
LGTM, thanks. did you mean to add a double-signed off by here? :) |
|
The double Signed-offs are just in case. |
|
nah, no problem. here on github (same for gitlab) we don't send emails so the sender email doesn't matter and you can adjust the git committer email to match whatever signed-off-by tag you prefer. IOW there's no need for a double sign off. |
|
I got it. I'll add an e-mail only matching my git committer e-mail. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that there was the unnecessary ID remained on libwacom.stylus
and Movink supports more groups for libwacom to work properly.