Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with the recently added SVG files #690

Merged
merged 4 commits into from
May 14, 2024

Conversation

whot
Copy link
Member

@whot whot commented May 14, 2024

  • Remove SVG files for tablets without rings/buttons/strips/dials. Those are just a single rect, we don't need those
  • Remove a , separating the groups, this looks like a leftover from a runaway script
  • Remove a rect that snuck its way into the Huion Mini Keydial

Related to #659, cc @JoseExposito

whot added 4 commits May 14, 2024 13:36
These are just a rectangle, so no point providing them.
If a device doesn't have buttons/rings/dials/strips we don't need an SVG
as our SVG won't have any content.
Looks like a copy/paste that snuck into all the new generated files.

Fixes: ce093e7 ("Add auto generated HUION tablet description files")
Fixes: c80bd7f ("Add auto generated GAOMON tablet description files")
@whot whot merged commit dc37190 into linuxwacom:master May 14, 2024
14 checks passed
@JoseExposito
Copy link
Contributor

Remove a , separating the groups, this looks like a leftover from a runaway script

Thanks! I removed it from the generator script in case we need to run it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants