Fix the pytest invocation #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whot
force-pushed
the
wip/pytest-fixes
branch
3 times, most recently
from
5feb8d0 to
2e28364
Compare
meson always sets ASAN_OPTIONS/UBSAN_OPTIONS even where they're not used which lead to us skipping the various SVG tests during meson test. Instead move this to meson.build and just run pytest if sanitize is off.
In the meson test run, split the pytests across multiple invocations. This makes it slighly easier to debug and also avoids any timeout issues since we no longer have one long test run.
|
ftr, this change still skips the hwdb checks in the CI because of Need to fix that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meson always sets
ASAN_OPTIONSso the SVG tests didn't actually run in our CI. oops.Filing as draft because pretty much all the SVGs added in #659 are missing some bits so they need to get fixed one-by-one.