Skip to content

Commit

Permalink
pdf backend: Ignore FullScreen PageMode catalog entry (#633)
Browse files Browse the repository at this point in the history
Prior to this change, Xreader would open in full screen mode if a PDF had the
PageMode entry in its catalog dictionary set to FullScreen. As this behavior
is generally unwanted by the consumer of a PDF document, this entry is
now ignored.
  • Loading branch information
mpetroff authored May 8, 2024
1 parent 1cde192 commit 5407f93
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion backend/pdf/ev-poppler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,9 @@ pdf_document_get_info (EvDocument *document)
info->mode = EV_DOCUMENT_MODE_USE_OC;
break;
case POPPLER_PAGE_MODE_FULL_SCREEN:
info->mode = EV_DOCUMENT_MODE_FULL_SCREEN;
// Ignore full screen page mode, since automatically opening
// in full screen mode is generally unwanted behavior
//info->mode = EV_DOCUMENT_MODE_FULL_SCREEN;
break;
case POPPLER_PAGE_MODE_USE_ATTACHMENTS:
info->mode = EV_DOCUMENT_MODE_USE_ATTACHMENTS;
Expand Down

0 comments on commit 5407f93

Please sign in to comment.