NFS: Fix a page leak in nfs_destroy_unlinked_subrequests()

commit add42de upstream. When we detach a subrequest from the list, we must also release the reference it holds to the parent. Fixes: 5b2b518 ("NFS: Fix nfs_page_group_destroy() and nfs_lock_and_join_requests() race cases") Cc: [email protected] # v4.14+ Signed-off-by: Trond Myklebust <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
linuxkit · Apr 17, 2020 · 194a805 · 194a805
1 parent 83dc8f0
commit 194a805
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
@@ -432,6 +432,7 @@ nfs_destroy_unlinked_subrequests(struct nfs_page *destroy_list,
 		}
 
 		subreq->wb_head = subreq;
+		nfs_release_request(old_head);
 
 		if (test_and_clear_bit(PG_INODE_REF, &subreq->wb_flags)) {
 			nfs_release_request(subreq);