Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 控制中心标题栏返回按钮消失 #588

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix: 控制中心标题栏返回按钮消失 #588

merged 1 commit into from
Jul 15, 2024

Conversation

Whale107
Copy link
Contributor

DTK清除多余space使用的方法有问题,应使用itemAt而不是takeAt

Log: 控制中心标题栏返回按钮消失
Bug: https://pms.uniontech.com/bug-view-264379.html
Influence: 控制中心-标题栏

DTK清除多余space使用的方法有问题,应使用itemAt而不是takeAt

Log: 控制中心标题栏返回按钮消失
Bug: https://pms.uniontech.com/bug-view-264379.html
Influence: 控制中心-标题栏
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • dynamic_cast 应该使用 itemAt 方法来获取布局中的项目,而不是 takeAt 方法。
  • delete 操作应该在确认 QSpacerItem 已经被正确移除后再进行。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 15, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#588
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Whale107 Whale107 merged commit 3a01bae into linuxdeepin:master Jul 15, 2024
19 of 21 checks passed
@Whale107 Whale107 deleted the github-master branch July 18, 2024 09:49
mhduiy pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Aug 20, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#588
Whale107 added a commit to Whale107/dtkwidget that referenced this pull request Aug 28, 2024
DTK清除多余space使用的方法有问题,应使用itemAt而不是takeAt

Log: 控制中心标题栏返回按钮消失
Bug: https://pms.uniontech.com/bug-view-264379.html
Influence: 控制中心-标题栏
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants